collective / collective.workspace

Restricted workspaces for Plone
7 stars 11 forks source link

Tests and basic documentation #1

Closed mattss closed 10 years ago

mattss commented 10 years ago

@davisagli We have added a basic README (based on some of your previous explanations of the package), some docstrings on key methods and a couple of tests.

mattss commented 10 years ago

Further apologies for submitting a pull request that apparently breaks the tests. Working on a fix now!

mattss commented 10 years ago

@davisagli We've now resolved the issue with re-setting groups, and fixed the tests.

davisagli commented 10 years ago

Gah, sorry for the slow follow-up; I've been away camping for the last 5 days. This looks good now!

mattss commented 10 years ago

Thanks for this! Are you happy for a release to be made to pypi?

davisagli commented 10 years ago

Yes, go for it!

David Glick (mobile)

On Jul 3, 2014, at 3:35 AM, mattss notifications@github.com wrote:

Thanks for this! Are you happy for a release to be made to pypi?

— Reply to this email directly or view it on GitHub.

mattss commented 10 years ago

After some initial distribution issues - the release is out!

davisagli commented 10 years ago

Thanks, I owe you guys a drink at the conference. Also, I think it's hilarious that a bunch of Brits released my software on US Independence Day :) :us: