collective / cookiecutter-plone-starter

Cookiecutter Plone Starter is a framework for jumpstarting Plone 6 projects quickly.
MIT License
19 stars 10 forks source link

Cannot `make install` #38

Closed stevepiercy closed 1 year ago

stevepiercy commented 1 year ago

After creating a project with cookiecutter gh:collective/cookiecutter-plone-starter, I try make install. It proceeds to install the backend successfully, then tries to install the frontend, but eventually fails.

warning "@storybook/react > @storybook/core > @storybook/core-server > @storybook/builder-webpack4@6.5.13" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
[5/5] 🔨  Building fresh packages...
[7/7] â „ @plone/volto
[-/7] â¡€ waiting...
[-/7] â¡€ waiting...
[-/7] â¡€ waiting...
error /Users/stevepiercy/projects/plone-conference/frontend/node_modules/@plone/volto: Command failed.
Exit code: 1
Command: yarn patches
Arguments: 
Directory: /Users/stevepiercy/projects/plone-conference/frontend/node_modules/@plone/volto
Output:
Usage Error: The nearest package directory (/Users/stevepiercy/projects/plone-conference/frontend/node_modules/@plone/volto) doesn't seem to be part of the project declared in /Users/stevepiercy/projects/plone-conference/frontend.

- If /Users/stevepiercy/projects/plone-conference/frontend isn't intended to be a project, remove any yarn.lock and/or package.json file there.
- If /Users/stevepiercy/projects/plone-conference/frontend is intended to be a project, it might be that you forgot to list node_modules/@plone/volto in its workspace configuration.

make[2]: *** [install] Error 1
make[1]: *** [install-frontend] Error 2
make: *** [install] Error 2

Summary:

sneridagh commented 1 year ago

@stevepiercy it should work with latest V16a50.

@ericof @jensens Hesitating if force latest @plone/generator-volto alpha in the install, since we'll have to undo the change after we release the final.

ericof commented 1 year ago

@sneridagh I will work on that today (as we also need to fix Makefile and Dockerfile) for the latest Volto release to work.

sneridagh commented 1 year ago

@stevepiercy @ericof @jensens https://github.com/collective/cookiecutter-plone-starter/pull/39

sneridagh commented 1 year ago

@ericof just saw your comment, then Dockerfile and Makefile amendments are due.

stevepiercy commented 1 year ago

OK, I am also watching #40. Please let me know when I should try it out to confirm all works as intended. Thank you!

ericof commented 1 year ago

@stevepiercy Yes, test it

stevepiercy commented 1 year ago

Let's do two more merges while we are at it before I test.

stevepiercy commented 1 year ago

Looking good so far:

Summary:
  - Plone version: 6.0.0b3
  - Volto version: 16.0.0-alpha.50
  - Volto Generator version: 6.0.0-alpha.3
  - Output folder: /Users/stevepiercy/projects/plone-conference

...and make install got through frontend install. Closing.

I might refine the Training docs further. Thank you!