collective / dexterity.membrane

enables dexterity content items to be used as users and groups in Plone sites
3 stars 14 forks source link

Could we remove collective.indexing #10

Closed toutpt closed 6 years ago

toutpt commented 10 years ago

Collective.indexing goal is to improve performance by change the way Plone's catalog is working. It has nothing to do with membrane.

This is not a dependency but it's better to use because membrane use a lot the catalog. So I believe this is a project decision to use collective.indexing but not an addon decision.

With the version 2.0 of indexing there is not anymore issues while removing it.

I have tagged this issue with question because I want opinion. And with bug because this is not a dependency.

hvelarde commented 10 years ago

:+1:

anyway, I think it should be documented on the README file if @mauritsvanrees recomends its usage.

datakurre commented 10 years ago

-1

AFAIK this product should not work as intended without collective.indexing, because it's required by Products.membrane to index Dexterity-based content, because Dexterity does not support catalog multiplexing. Yet c.indexing is an optional dependency for membrane, because of some issues with Archetypes. This is documented in... well... Products.membrane's changelog.

See also:

davisagli commented 10 years ago

If I recall correctly, collective.indexing is required to make sure that items end up in the membrane_tool catalog in addition to portal_catalog, since Dexterity doesn't support catalog multiplexing like Archetypes does. It does not matter whether you turn deferred indexing on or not.

I would certainly love to have something that provided functionality similar to membrane without using a separate catalog, though. I just did a bit of analysis of a site that has 100,000 dexterity.membrane-based members, and the membrane_tool catalog is almost as large as the portal_catalog in terms of number of objects and pickle size. It seems like we could get by with just a handful of extra indexes in the main catalog, but I haven't thought about it in detail yet.

agitator commented 6 years ago

c.indexing was merged into Plone 5.1 and dx.membrane is updated to work with 5.1