collective / dexterity.membrane

enables dexterity content items to be used as users and groups in Plone sites
3 stars 14 forks source link

Fix username support #19

Closed petri closed 7 years ago

petri commented 8 years ago

Currently, if use_email_as_username registry setting is set to False, anything that is based on DxUserObject but does not provid a username attribute, will fail: see line 81 of DxUserObject class implementation.

As such, the bug affects also the example Member type that is provided by this package.

Assuming there are no downsides I've missed, I'll submit a PR containing:

gyst commented 7 years ago

To further complicate matters, the username field is actually used to store the userid. See #26.

mauritsvanrees commented 7 years ago

I have released dexterity.membrane 1.2 with the fix from Guido.