search

collective / dexterity.membrane

enables dexterity content items to be used as users and groups in Plone sites
3 stars 14 forks source link

Fix & improve Group implementation #20

Open petri opened 8 years ago

petri commented 8 years ago

See #17 for background.

petri commented 8 years ago

Note that the PR Travis run is only failing on Plone 4.2, and the branch the PR is from, passes. No idea why the discrepancy; there seems to be some buildout version issue on Travis Plone 4.2 PR test run that's not present when Travis runs the branch.

mauritsvanrees commented 8 years ago

Thanks for your contribution. Looks okay at first glance.

The group content type should be added to membrane_tool.xml otherwise it does not end up in the membrane_tool catalog, which means for example that it does not show up on the sharing tab.

A test would be good. Something like: create a group and a user in it, give the group a global or local role, and then check if the user inherits this role.