collective / dexterity.membrane

enables dexterity content items to be used as users and groups in Plone sites
3 stars 14 forks source link

Added IProvidePasswords to membranepassword #24

Closed mikejmets closed 8 years ago

mikejmets commented 8 years ago

Because I haven't found a way to upgrade existing content to work on 1.1.1, I added IProvidePasswords to the membranepassword.py. Ideally I should have create an upgrade script to fix the issues I'm experiencing (see issue #23) - anyone know where to start?

mauritsvanrees commented 8 years ago

So this workaround fixes it for you, right? The upgrade script would only be for being able to avoid the workaround.

Looks good to me like this. There is an unrelated Travis failure on Plone 4.2. I am handling that in pull request #25 and will revisit this then.

mikejmets commented 8 years ago

Yes, the workaround does work for me. After looking at the link you provided, it looks like do3cc has the script I was looking for. I'll test it asap.

mauritsvanrees commented 8 years ago

Well, the workaround is sane, and we already have one of those. An upgrade script (or a real fix in the upstream packages) would be good in general, not specific for dexterity.membrane. Travis complains on 4.2, but I have fixed the root error on master, so after merge it should be fine. I will do that. Thanks!