collective / dexterity.membrane

enables dexterity content items to be used as users and groups in Plone sites
3 stars 14 forks source link

Added view to default_methods on example member's FTI #38

Open mikejmets opened 5 years ago

mikejmets commented 5 years ago

Added view to default_methods on example member's FTI because cloning content type failed in @@dexterity-types

Steps to reproduce: In @@dexterity-types, select Member and click Clone

This returns:

Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module plone.z3cform.layout, line 63, in __call__
  Module plone.z3cform.layout, line 47, in update
  Module z3c.form.form, line 228, in update
  Module plone.app.z3cform.csrf, line 22, in execute
  Module z3c.form.action, line 98, in execute
  Module z3c.form.button, line 315, in __call__
  Module z3c.form.button, line 170, in __call__
  Module z3c.form.form, line 257, in handleAdd
  Module z3c.form.form, line 263, in createAndAdd
  Module plone.app.dexterity.browser.clone_type, line 29, in create
  Module plone.dexterity.fti, line 145, in __init__
  Module Products.CMFCore.TypesTool, line 160, in __init__
  Module Products.CMFDynamicViewFTI.fti, line 106, in manage_changeProperties
ValueError: view not in ('base_view',)
jean commented 5 years ago

@mauritsvanrees sorry for bothering; does this look OK to merge?

mauritsvanrees commented 5 years ago

LGTM. Fine to merge. I wonder if base_view could be removed then. Haven't checked.