search

collective / dexterity.membrane

enables dexterity content items to be used as users and groups in Plone sites
3 stars 14 forks source link

Fix the MembraneGroup #40

Closed b4oshany closed 5 years ago

b4oshany commented 5 years ago

Changed factory class from IMembraneGroup to MembraneGroup

mauritsvanrees commented 5 years ago

LGTM, but I haven't tried it locally, and am not using membrane currently.

@cedricmessiant You changed this the other way around in cdc91d4dc6e60021040dfda31d41e214d9afd7a2. Do you remember if this was intentional? The commit was four years ago, so probably hard to say...

Travis completely fails, which has nothing to do with this PR. Would be good to fix, but could be done on another PR. Locally the tests pass with the current PR branch.

cedricmessiant commented 5 years ago

@mauritsvanrees No, I really don't remember, seems good.

mauritsvanrees commented 5 years ago

Merged.

BTW, see earlier issue #17 and PR #20 that has this same change plus more.