search

collective / dexterity.membrane

enables dexterity content items to be used as users and groups in Plone sites
3 stars 14 forks source link

Added uninstall profile #45

Closed agitator closed 5 years ago

agitator commented 5 years ago

Made some additions... To really get rid of membrane a lot more is necessary depending on the actual use. I got rid of membrane in my project with those and more manual steps ...

I'm fine with not merging this and leaving it as some kind of example.

If anyone has the need for more, feel free to continue ;-)

mauritsvanrees commented 5 years ago

I fixed an XML error in configure.zcml. The instance did not start up. Hint: do not use an ampersand there. :-) I pushed another fix that should help with Travis.

My other remarks still stand, about testing, and possibly removing our behaviours from all portal types. And I see that the example content profile is still marked as installed. But your PR is an improvement, so if at least one of the Travis jobs passes, I am fine with merging this, if no one objects. (Note: I do not use this package.)

mauritsvanrees commented 5 years ago

Code analysis fails on Travis because it cannot startup due to python2/3 version problems. But: "The command "bin/test --all" exited with 0." I will merge.

agitator commented 5 years ago

I realised the ampersand thing also in another pr, you were faster here ;-) thx @mauritsvanrees