search

collective / dexterity.membrane

enables dexterity content items to be used as users and groups in Plone sites
3 stars 14 forks source link

Udpate profile #65

Closed petschki closed 1 year ago

ale-rt commented 1 year ago

I do not get the reason for this change :) I am fine with it but I would separate the actual work of renaming the profile from the one that updates the package testing infrastructure.

Also note that this removes from the tests Plone 5.1, which is fine for me, but deserves a mention in the changelog, in the readme and some fixes for the setup.py.

We could even remove Python 2.7 support and I believe none will blame us :)

The important thing is that this is achieved through separate PR because it will help to reconstruct what happened.

petschki commented 1 year ago

OK, you're right. This PR fixes some needs for my latest project. Mainly I wanted to add a uninstall profile for the example profile.

Why I've renamed it? Because the profile adds the dexterity_membrane_workflow which is mandatory because the login checks for in_right_state here https://github.com/collective/dexterity.membrane/blob/master/dexterity/membrane/behavior/password.py#L188 so I thought the name example isn't really a good one for its purpose.

petschki commented 1 year ago

Created a new PR with only profile renaming commits #66