search

collective / gatsby-starter-plone

Gatsby starter for Plone
https://collective.github.io/gatsby-starter-plone/
MIT License
4 stars 3 forks source link

What method to import gatsby-source-plone? #1

Closed ajayns closed 6 years ago

ajayns commented 6 years ago

For local dev yarn link I'm using but for updating the package.json with the dependency, since we haven't published our package on npm yet, what'd be the best way to import?

I'm thinking we could use a github import:

"gatsby-source-plone": "git+ssh://git@github.com/collective/gatsby-source-plone.git"

@datakurre @cekk

datakurre commented 6 years ago

yarn link is good for now

github link would not work as such, because unreleased version must be manually compiled On 23 Jul 2018, 10.19 +0300, Ajay NS notifications@github.com, wrote:

For local dev yarn link I'm using but for updating the package.json with the dependency, since we haven't published our package on npm yet, what'd be the best way to import? I'm thinking we could use a github import: "gatsby-source-plone": "git+ssh://git@github.com/collective/gatsby-source-plone.git" — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ajayns commented 6 years ago

Actually, since we have an npm prepare script, on installing dependencies, it does the compilation as well.

datakurre commented 6 years ago

@ajayns Ok. If git+ssh works, it is ok.

datakurre commented 6 years ago

@ajayns As said, "gatsby-source-plone": "git+ssh://git@github.com/collective/gatsby-source-plone.git" is ok.

ajayns commented 6 years ago

Yes, will make the changes. I hadn't changed thinking maybe we'll ship the npm package soon.