Enable offline and PWA -plugins

datakurre commented 6 years ago

Should we enable offline and PWA -plugins by default? Is there any reason not to enable them? (I assume the offline-plugin does cache invalidation right...)

@polyester Opinion, should gatsby-starter-plone come with PWA and offline -features enabled by default?

The current build result: https://collective.github.io/gatsby-starter-plone/

polyester commented 6 years ago

I don't have a strong opinion; either enabled by default or commented out (so that enabling it is just a question of uncommenting) is fine by me.

tisto commented 6 years ago

Enable by default.

datakurre commented 6 years ago

@tisto https://collective.github.io/gatsby-starter-plone/

@ajayns I added and configured manifest and offline plugins. Mixed experience:

build --prefixPaths was broken with the latest Gatsby (probably after reach/router -merge), but works with the currently locked versions https://github.com/gatsbyjs/gatsby/issues/7163
manifest-plugin does not prefix icon paths and therefore manifest contains broken icon paths
offline plugin feels flaky on iOS, but maybe iOS support for service workers is still buggy

collective / gatsby-starter-plone

Enable offline and PWA -plugins #14