search

collective / gatsby-starter-plone

Gatsby starter for Plone
https://collective.github.io/gatsby-starter-plone/
MIT License
4 stars 3 forks source link

Isn't the contributors guide needed on readme? #8

Open vikaskyadav opened 6 years ago

ajayns commented 6 years ago

Right now the prime focus is to complete the starter with all the major features, adding this guide has been left for later. But would be more than glad to accept PRs! :)

vinay72 commented 5 years ago

@ajayns Can I work on the contributor guide to add README.rst file for new contributors to know how to contribute to this repository?

ajayns commented 5 years ago

Sure! Maybe @cekk or @tisto can help us with a repo with a good contributors guide which can be used as reference.

vinay72 commented 5 years ago

@datakurre @ajayns Can I add this file in this repository by sending a PR? You can check this link : https://docs.plone.org/develop/coredev/docs/agreement.html .

datakurre commented 5 years ago

@vinay72 Just create a PR and discussion would be easier to handle in that PR.

Technically this package is not yet under Plone Foundation, so it does not require to follow those rules, but sure it would not do any harm to follow them.

vinay72 commented 5 years ago

@datakurre Whenever I try to push my commit from my remote branch, I am getting the following error in my terminal screenshot from 2019-02-11 01-13-30

datakurre commented 5 years ago

Yes, you need to fork the repository and create fork from the pull. That’s common practise. On 10 Feb 2019, 21.45 +0200, Vinay Sagar Sharma notifications@github.com, wrote:

@datakurre Whenever I try to push my commit from my remote branch, I am getting the following error in my terminal — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ajayns commented 5 years ago

Please read through the commonly used practices while contributing to open source and maybe work your way through Github before opening a proper PR. It doesn't make sense spamming this repo with PRs @vinay72

vinay72 commented 5 years ago

@ajayns I am sorry for inconvenience. I'll take care next time.