search

collective / i18ndude

i18ndude performs various tasks related to ZPT's, Python Scripts and i18n.
https://pypi.org/project/i18ndude
4 stars 9 forks source link

Warn about unexisting domain pot files? #19

Closed gforcada closed 9 years ago

gforcada commented 9 years ago

I'm not sure how that should be handled... Let me explain it:

I have a distribution named freitag.foo a few templates have the appropiate i18n:domain="freitag.foo" but alas ... you copy and paste one template from distribution freitag.bar and when running find-untranslated it does not complain because everything is marked as it should, but then the strings on that template are not being translated.

OTOH this is not bad per se as it allows you to reuse, say plone translations, but maybe that's not what you really want...

Any ideas?

mauritsvanrees commented 9 years ago

I think find-untranslated should not care about the domain. Standard use case would indeed be that you customize a Plone template: you don't want i18ndude to complain that there is no plone.pot file.

Possibly an extra command, like find-non-standard-domains, where you pass mydomain as argument and let it report any files that have i18n:domain="something.else". But that is basically the same as grep -r i18n:domain . | grep -v mydomain, which I would then prefer.

gforcada commented 9 years ago

Fair enough.