search

collective / i18ndude

i18ndude performs various tasks related to ZPT's, Python Scripts and i18n.
https://pypi.org/project/i18ndude
4 stars 9 forks source link

Find untranslated attributes now also checks for 'placeholder' attributes for input elements #42

Closed janjaapdriessen closed 7 years ago

janjaapdriessen commented 7 years ago

…utes on input tags.

janjaapdriessen commented 7 years ago

@mauritsvanrees I see you updated the tox configuration on master; I merged those changes into my branch and the travis check is now green. What do you think of the changes in this PR?

mauritsvanrees commented 7 years ago

Looks good and seems useful. I would like a test that shows that a placeholder with proper i18n:attributes is ignored, to be sure that this does not give a strange regression. I can actually do that easily myself. I will merge this locally and add the test. Thanks!

mauritsvanrees commented 7 years ago

I have released this in 4.2.