search

collective / i18ndude

i18ndude performs various tasks related to ZPT's, Python Scripts and i18n.
https://pypi.org/project/i18ndude
4 stars 9 forks source link

Remove ordereddict dependency in Python 2.7 #47

Closed mauritsvanrees closed 6 years ago

mauritsvanrees commented 7 years ago

With Python 2.7 we should be able to use from collections import OrderedDict. I briefly tried this, but ran into test failures:

Error in test test_read (i18ndude.tests.test_catalog.TestMessagePYReader)
Traceback (most recent call last):
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/Users/maurits/tools/src/i18ndude/src/i18ndude/tests/test_catalog.py", line 533, in test_read
    pyr.read()
  File "/Users/maurits/tools/src/i18ndude/src/i18ndude/catalog.py", line 744, in read
    self.domain)
  File "/Users/maurits/tools/src/i18ndude/src/i18ndude/catalog.py", line 755, in _add_msg
    self.catalogs[domain] = MessageCatalog(domain=domain)
  File "/Users/maurits/tools/src/i18ndude/src/i18ndude/catalog.py", line 158, in __init__
    OrderedDict.__init__(self, None)
  File "/usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/lib/python2.7/collections.py", line 69, in __init__
    self.__update(*args, **kwds)
  File "/Users/maurits/tools/src/i18ndude/bin/../lib/python2.7/_abcoll.py", line 571, in update
    for key, value in other:
TypeError: 'NoneType' object is not iterable