[RFC] handling of broken icals

[geier]

I would like to introduce some kind of handling of for broken/invalid icalendar files and would like your input on how to build this feature.

Some ideas off the top of my head:

three different (possible) modes:

• ignore [default]: just ignore every error (as we do currently)
• raise an exception the first time an invalid component is discovered
• collect all invalid component properties, add a broken or valid property to each component

[stlaz]

It seems that the third option is the closest to the solution they use in libical where components consist of lists of properties. If an error occurred during parsing they add an error property accordingly.

See https://github.com/libical/libical/blob/master/src/libical/icalparser.c#L562.

[thet]

I your option 3 and the approach of @stlaz . I think this is fixed by: https://github.com/collective/icalendar/pull/175 - if you diagree, please repoen.

[niccokunzmann]

@geier, now, there is some kind of recognition of broken ical files. Would you close this or could you specify closing critaria?

[niccokunzmann]

I commented here: https://github.com/collective/icalendar/issues/315#issuecomment-1281476631 - I would do both - add a broken/valid property and not raise an exception but a warning.

[geier]

I don't really care about this issue, but we probably still should implement the suggested features (warnings and some kind of validate function).