Improved test coverage in 5 places for production code

collective / icalendar

icalendar parser library for Python

https://icalendar.readthedocs.io

Other

1k stars 172 forks source link

Closed mtrd3v closed 4 months ago

mtrd3v commented 4 months ago

This PR fixes issue #629 by Improving test coverage in 5 places for production code

coveralls commented 4 months ago

niccokunzmann commented 4 months ago

Thanks!

While looking through it: you found mistakes in the code by improving the coverage. 🥳

could you correct that too or create an issue for it?

vCalAddress('b'value'') repr should be vCalAddress('value')

and vBinary repr probably vBinary(b'value')

My guess is that changing python 2 to 3 did this.

mtrd3v commented 4 months ago

Thanks for reviewing my PR. I have corrected them.

niccokunzmann commented 4 months ago

Could you merge master?

mtrd3v commented 4 months ago

I have fixed the issue. Now you can check.

niccokunzmann commented 4 months ago

@mtr-d3v Thanks! I just merged master so there is no conflict. It seems that the tests are updated and fail.

I am wondering why not all the tests were running before ...

mtrd3v commented 4 months ago

I have fixed the repr for vBinary and vCalAddress, the tests should pass now.

niccokunzmann commented 4 months ago

Thank you very much!