Tested with dateutil timezones

collective / icalendar

icalendar parser library for Python

https://icalendar.readthedocs.io

Other

1k stars 171 forks source link

Tested with dateutil timezones #732

Open mtrd3v opened 1 month ago

mtrd3v commented 1 month ago

This PR will fix the issue #691.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11329186809

Details

20 of 38 (52.63%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 96.882%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/icalendar/timezone/dateutil.py	20	38	52.63%
<!--	Total:	20	38	52.63%	-->

Totals
Change from base Build 11317448813:	-0.5%
Covered Lines:	3520
Relevant Lines:	3630

💛 - Coveralls

niccokunzmann commented 1 month ago

Hi, thanks for submitting this. Please add the test fixture param so that all tests also run with this timezone provider. I will hesitate to ship untested code and claim that it would work.

[ ] parametrize tests https://github.com/collective/icalendar/blob/8cd6823251f41aa2202584fd0ae68e7bcffe2840/src/icalendar/tests/conftest.py#L235
[ ] add documentation on how to switch to dateutil
[ ] add tests to make sure edge cases are considered (I do not know which ones these are)

mtrd3v commented 1 month ago

We are currently working on it. Will do that!

niccokunzmann commented 1 month ago

Have fun! I will be back tomorrow possibly :)

niccokunzmann commented 1 month ago

If you need any help or you would like a review, please do not hesitate to notify us here. Thanks for the work!