collective / lineage.themeselection

Theme Selection for Lineage Child-Sites
https://pypi.org/project/lineage.themeselection/
Other
4 stars 1 forks source link

theme tab broken in plone 4.3 #2

Closed jensens closed 9 years ago

jensens commented 10 years ago

assigning a diazo theme does not work in plone 4.3 anymore. Error:

2013-10-07 11:46:03 ERROR Zope.SiteErrorLog 1381139163.280.609784463215 http://localhost:8080/Plone/childsite/@@theming-controlpanel Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module plone.app.theming.browser.controlpanel, line 50, in call Module plone.app.theming.browser.controlpanel, line 72, in update Module plone.app.theming.browser.controlpanel, line 61, in _setup TypeError: ('Could not adapt', ATFolder at /Plone/childsite, InterfaceClass plone.app.controlpanel.skins.ISkinsSchema)

thet commented 10 years ago

solved by: https://github.com/collective/lineage.themeselection/commit/f0b249383546ae451a62b16538da65c6ca0ec405 https://github.com/collective/lineage.themeselection/commit/3b64addc45c2647f1168bbc1ec5cda4e5ccc6736 https://github.com/collective/lineage.themeselection/commit/87802223533031d015cdd1d8afe0fa876340d917

the skins controlpanel section in the merged diazo/skins controlpanel does not work properly - it sets the skin globally and not only for the subsite. therefore, this section is disabled in https://github.com/collective/lineage.themeselection/commit/3b64addc45c2647f1168bbc1ec5cda4e5ccc6736

if this solution is ok, please close this ticket.

frisi commented 9 years ago

@jensens can this be closed? if yes, i'd be glad if you guys do a new release or give me permission on pypi (user frisi)

jensens commented 9 years ago

afaict its solved. access granted thanks!

thet commented 9 years ago

by the way, @frisi can you grant me pypi access to lineage.index? there's a fix waiting to be released: https://github.com/collective/lineage.index/commit/c091f96345fb525853db4951f0cb8651b3ad8abe

frisi commented 9 years ago

@thet i commented your checkin https://github.com/collective/lineage.index/commit/c091f96345fb525853db4951f0cb8651b3ad8abe#commitcomment-8650445 and gave you permission on pypi

frisi commented 9 years ago

@jensens released, thanks!