collective / lineage.themeselection

Theme Selection for Lineage Child-Sites
https://pypi.org/project/lineage.themeselection/
Other
4 stars 1 forks source link

Thet plone5 #6

Closed thet closed 8 years ago

thet commented 8 years ago

IMO, this changes make a good 2.0 release.

I don't like the name LineageSubsiteFacade but could not come up with a better name. Suggestions?

Also, maybe LineageSubsiteFacade from themingcontrolpanel.py shouldn't be used in apply_theme from subscriber.py, because it was intended only to trick the LineageThemingControlPanel to set the skin settings into the local registry. Instead, I could just access the registry directly. IMO it's ok to use this in upgrades.py though. I'm indifferent if I should change this. Opinions?

/cc @jensens @frisi

jensens commented 8 years ago

indeed this is a major change. I dont bother what the class name is. Facade pattern matches somehow, even if not 100%.

I'll merge, lets use it in our projects for a short while and then release a 2.0b1.