Set the childsite skin on a lineage.registry based local registry instead of an lineage_theme attribute on an IChildSite object. Includes an upgrade step.
Allow setting of lineage_theme skin setting through the @@theming-controlpanel and remove the customized controlpanel template, Archetypes schemaextender and Dexterity behavior. This works for plone.app.theming1.1.x and 1.2.x. Includes an upgrade step.
I don't like the name LineageSubsiteFacade but could not come up with a better name.
Suggestions?
Also, maybe LineageSubsiteFacade from themingcontrolpanel.py shouldn't be used in apply_theme from subscriber.py, because it was intended only to trick the LineageThemingControlPanel to set the skin settings into the local registry. Instead, I could just access the registry directly. IMO it's ok to use this in upgrades.py though.
I'm indifferent if I should change this.
Opinions?
IMO, this changes make a good 2.0 release.
lineage.registry
based local registry instead of anlineage_theme
attribute on anIChildSite
object. Includes an upgrade step.lineage_theme
skin setting through the@@theming-controlpanel
and remove the customized controlpanel template, Archetypes schemaextender and Dexterity behavior. This works forplone.app.theming
1.1.x
and1.2.x
. Includes an upgrade step.I don't like the name
LineageSubsiteFacade
but could not come up with a better name. Suggestions?Also, maybe
LineageSubsiteFacade
fromthemingcontrolpanel.py
shouldn't be used inapply_theme
fromsubscriber.py
, because it was intended only to trick theLineageThemingControlPanel
to set the skin settings into the local registry. Instead, I could just access the registry directly. IMO it's ok to use this inupgrades.py
though. I'm indifferent if I should change this. Opinions?/cc @jensens @frisi