search

collective / mockup-minimalpattern

Minimal pattern for learning pattern creation
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

Does import but works with no effect; Bundle does not compile in plone 5 #2

Open volkerjaenisch opened 8 years ago

volkerjaenisch commented 8 years ago

Hi! Cloned via git, bootstrapped, included in buildout as dev package, imported into plone. @@minimalpatterndemo is accessible but does not work - only 3 times "uh-what". Resource registry shows the resources and the bundle correctly. Trying to compile the bundle results in "NetworkError: 404 Not Found - http://localhost:8080/Plone/pat-base.js"

I noticed that in Mockup the name for the base component is "mockup-pattern-base" and not "pat-base" as in the config.js of mockup-minimalpattern. May that be the cause?

Best regards Volker

volkerjaenisch commented 8 years ago

As expected. Changing "pat-base" to "mockup-pattern-base" solved the problem. Seems that this minimal-pattern and the Mockup-Package in Plone 5 are slightly diverging.

gforcada commented 8 years ago

Would you mind providing a pull request to fix it?

volkerjaenisch commented 8 years ago

Hi!

I am no JS professional. But I can try.

Best

Volker

Am 29.02.2016 um 22:58 schrieb Gil Forcada Codinachs:

Would you mind providing a pull request to fix it?

— Reply to this email directly or view it on GitHub https://github.com/collective/mockup-minimalpattern/issues/2#issuecomment-190415962.

inqbus Scientific Computing Dr. Volker Jaenisch Richard-Strauss-Straße 1 +49(08861) 690 474 0

86956 Schongau-West http://www.inqbus.de

thet commented 8 years ago

Oh, mockup-minimalpattern wasn't updated for changes in mockup 2.0, where it was brought closer to Patternslib. Should be updated for that..... I'll review, if you make a pull reuqest.

volkerjaenisch commented 8 years ago

Hi !

Am 01.03.2016 um 11:58 schrieb Johannes Raggam:

Oh, mockup-minimalpattern wasn't updated for changes in mockup 2.0, where it was brought closer to Patternslib. Should be updated for that..... I'll review, if you make a pull reuqest.

While reviewing the initial problem (wrong dependencies to old mockup) I noticed new problems that are not repeatable. The behavior of the plone TTW compile is erratic. Some times it works then it refuses to work (Time out, without a reason (no missing files)). This is dependend on code changes, deleting of resources TTW and reinstalling the package.

To gain more insight: Is there a way to look into the TTW compile process? Without at least a stacktrace and a way to debug nobody can rely on the TTW compile.

Beste regards,

Volker

inqbus Scientific Computing Dr. Volker Jaenisch Richard-Strauss-Straße 1 +49(08861) 690 474 0

86956 Schongau-West http://www.inqbus.de