search

collective / pas.plugins.ldap

Zope (and Plone) PAS Plugin providing users and groups from LDAP directory
http://pypi.python.org/pypi/pas.plugins.ldap
Other
13 stars 20 forks source link

Uninstall leaves the PAS plugin behind #25

Closed hvelarde closed 7 years ago

hvelarde commented 7 years ago

selection_073

You'll see the following in your instance event log:

2016-09-28 11:15:53 WARNING pas.plugins.ldap LDAPError in authenticateCredentials -> {'desc': "Can't contact LDAP server"}

The workaround is to remove the PAS plugin from the ZMI.

hvelarde commented 7 years ago

I was trying to add tests to demonstrate the issue but you have a non-standard test setup in this package and I don't know how to do it; any guidance is appreciated.

jensens commented 7 years ago

Overall yes, this is an issue.

jensens commented 7 years ago

Btw, I left the plugin intentionally behind. Otherwise its settings are vanished. And since people like to click in Add-Ons control-panel on uninstall/ install, because they believe it would fix something, this is probably a good idea.

We may want to disable the plugin in plugin registry on uninstall and enable it there if it is already there.

rnixx commented 7 years ago

I updated the todo list in #36

hvelarde commented 7 years ago

@jensens I think that's not a good idea (but that's only what I think): all add-ons remove their configuration on uninstall and we must keep consistency.

rnixx commented 7 years ago

In a perfect world some has a GS profile with LDAP config stored. In real world we have all but the perfect world. LDAP configuration can be tricky, thus I think it's a good idea to keep but disable the Plugin on a thoughtlessly triggered Uninstall

hvelarde commented 7 years ago

I'm totally fine with your rationale, just don't forget to document that on the README file, please.

also, what happens if I remove the pas.plugins.ldap egg after uninstalling? is that going to break my site?

jensens commented 7 years ago

Go to ZMI and remove the plugin before.

hvelarde commented 7 years ago

so that also needs to be documented in the README file; now you understand why I want to discuss every issue on a separate basis: not because I want to bug you, guys, but because I want us to have the best quality on our software.

@rnixx I'm sorry for any misunderstanding.

I think is better to remove completely the package and document how to export the settings, than to leave thing behind.