collective / pas.plugins.ldap

Zope (and Plone) PAS Plugin providing users and groups from LDAP directory
http://pypi.python.org/pypi/pas.plugins.ldap
Other
13 stars 20 forks source link

yafowil necessary with plone5? #57

Closed krissik closed 5 years ago

krissik commented 6 years ago

Hi all, I have plone 5.1rc1installed. On every page load I see yafowils css and javascript loading without being cached:

yafowil-loading-without-cache

Because of that https://github.com/collective/pas.plugins.ldap/blob/db74d1e1694d4917299a74b40cd5e3bc2df065d0/src/pas/plugins/ldap/plonecontrolpanel/configure.zcml#L27 I am wondering if I really need it. Is it save to disable it in resource registry?

Krissi

rnixx commented 6 years ago

The p.p.ldap controlpanel form is done with yafowil. The proper way to solve this issue would be to cache the views in https://github.com/bluedynamics/yafowil.plone/blob/master/src/yafowil/plone/resources.py

zopyx commented 6 years ago

This relates to

https://github.com/bluedynamics/yafowil.plone/issues/15

and must be addressed to due the overhead of 0.5-0.7 seconds per request in our case.

jensens commented 5 years ago

We wont kick out YAFOWIL unless there are better widgets for z3c.forms (good dict and array widgets).

But we can solve the problem of loading the resources on every request. This is addressed by https://github.com/bluedynamics/yafowil.plone/pull/21

jensens commented 5 years ago

Answer is YES.

Now I can close it here ;)