coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 4424305312
- 14 of 44 (31.82%) changed or added relevant lines in 2 files are covered.
- 55 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-4.9%) to 53.704%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/pas/plugins/oidc/plugins.py | 12 | 17 | 70.59% | ||
| src/pas/plugins/oidc/browser/view.py | 2 | 27 | 7.41% | ||
| <!-- | Total: | 14 | 44 | 31.82% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/pas/plugins/oidc/browser/view.py | 1 | 30.41% | ||
| src/pas/plugins/oidc/plugins.py | 54 | 62.03% | ||
| <!-- | Total: | 55 | --> |
| Totals | |
|---|---|
| Change from base Build 4227371869: | -4.9% |
| Covered Lines: | 232 |
| Relevant Lines: | 432 |
Fixes #18
I know that catching generic exceptions is not a good thing.
We have been seeing error in these places when connecting with a OIDC provider, all of them are connection issues (timeouts etc.) but I can't find specific exceptions for them.
What do you think @mamico @mauritsvanrees ?