search

collective / pas.plugins.sqlalchemy

SQLAlchemy PAS plugin (Authentication) for Zope2/ Plone
http://plone.org/products/pas.plugins.sqlalchemy/
7 stars 7 forks source link

Small changes #3

Closed rudaporto closed 13 years ago

rudaporto commented 13 years ago

I found two small problems to use pas.plugins.sqlalchemy and fix it.

auspex commented 13 years ago

Thanks rudaporto - I'd found that first one, but hadn't got around to committing it...

rudaporto commented 13 years ago

auspex I'm doing lot of work pythonbrasil fork:

1) make compatible with Plone 3.3.X and Python 2.4/Zope2.9 2) fix rolemanager integration bug with userprefs control panel UI on Plone4 3) create new test case base class and suite to run functional and doctests

I'll be happy if someone can review these changes, run tests and let me know what need to be improved ;-)

malthe commented 13 years ago

I think looks mostly good; in general, I don't like testing against Plone views because it's brittle and it's very hard to get the coverage you want. I'd have preferred proper unit tests. It's easier to maintain and refactor, too.

rudaporto commented 13 years ago

malthe, I agree with you, mostly (I took some time to make it work)

But this test was motivated by the rolemanager integration bug, and is a step to create a better integration with Plone UI in general.

As I said (on commit comment), should we create a new package for better Plone integration?