search

collective / pas.plugins.sqlalchemy

SQLAlchemy PAS plugin (Authentication) for Zope2/ Plone
http://plone.org/products/pas.plugins.sqlalchemy/
7 stars 7 forks source link

Regression, but where...? #6

Closed auspex closed 13 years ago

auspex commented 13 years ago

In April, I committed: https://github.com/collective/pas.plugins.sqlalchemy/commit/e661c514063e829828ac43757fe8989a3243f483 which iirc was absolutely necessary to permit users to be added to groups in Plone. Sometime since, it's been regressed, but I'm still not good enough with git to figure out where.

malthe commented 13 years ago

I did a very substantial merge between selected branches in the SVN collective repository against this git repo, and I may have missed out on a few details.

If / when you have time, please try and determine of all your commits have made it to the current HEAD.

Thanks and sorry !

auspex commented 13 years ago

No, not your problem - mine. At least mostly: there are three methods in that commit, and two of them are further down in the file now. The third doesn't seem to be there, but may well be superfluous (certainly surplus to my requirements, and other comments elsewhere suggest it might not be useful)

On Sun, Oct 16, 2011 at 3:44 AM, Malthe Borch < reply@reply.github.com>wrote:

I did a very substantial merge between selected branches in the SVN collective repository against this git repo, and I may have missed out on a few details.

If / when you have time, please try and determine of all your commits have made it to the current HEAD.

Thanks and sorry !

Reply to this email directly or view it on GitHub:

https://github.com/collective/pas.plugins.sqlalchemy/issues/6#issuecomment-2419650

derek