collective / plone.app.imagecropping

Crops Images in Plone manually using cropper JS library
https://pypi.python.org/pypi/plone.app.imagecropping
9 stars 23 forks source link

Test with Plone6.0.0.a4: ReferenceError: define is not defined #109

Closed krissik closed 2 years ago

krissik commented 2 years ago

I'm testing plone.app.imagecropping with Plone6.0.0a4. There was an error "ImportError: cannot import name 'IObjectEvent' from 'zope.component.interfaces'" which I have fixed here: https://github.com/krissik/plone.app.imagecropping/tree/plone6.0.0a4

But now I get JavaScript error when accessing "@@croppingeditor"

Uncaught ReferenceError: define is not defined
    <anonymous> plone_app_imagecropping-compiled.js:2995

and no idea how to fix it.

Does anyone have a hint how to fix?

petschki commented 2 years ago

since 6.0.0a4 the new ES6 JS resources are there, so you need to checkout master with the latest ES6 updates (see https://github.com/collective/plone.app.imagecropping/pull/110)