search

collective / plone.app.imagecropping

Crops Images in Plone manually using cropper JS library
https://pypi.python.org/pypi/plone.app.imagecropping
9 stars 23 forks source link

Update Jcrop to v0.9.12 #34

Closed hvelarde closed 10 years ago

hvelarde commented 10 years ago

Release 0.9.12 has been available for over a year; we need to update the package:

http://deepliquid.com/content/Jcrop_Download.html

We should thing also on taking the JS and CSS registration out of this package to make it easier to maintain.

frisi commented 10 years ago

thanks for updating jcrop.

i could not find any changelog on the jrop website or github page to see whether an update is important (eg bugix / extended browser support) or simply a new feature (that we won't use if we don't adapt the integration too)

i don't understand why it will be easier to maintain p.a.imagecropping if we move jcrop registration to another package (i.e. collective.js.jcrop)? for integrators at least, it will be harder since they need to take care that the version of p.a.imagecropping works with collective.js.jcrop)

hvelarde commented 10 years ago

seems to be a bugfix; and yes, you're probably right about taking the code out of the package.

I want to update it to use the new minimized version of the CSS also; just give me some time until we finish testing it.

saily commented 10 years ago

so this seems to be tested for me now. closing this.

frisi commented 10 years ago

dunno if this really can be closed. the current master still uses 0.9.10 (https://github.com/collective/plone.app.imagecropping/blob/master/src/plone/app/imagecropping/browser/static/jquery.Jcrop.min.js)

saily commented 10 years ago

ok, i thought this was merged already. I opened a new pull, see https://github.com/collective/plone.app.imagecropping/pull/42.