search

collective / robotframework-selenium2screenshots

Robot Framework keyword library for capturing annotated screenshots with Selenium2Library
28 stars 12 forks source link

Fixed "Crop page screenshot" to recognize scrolled position and pixel… #17

Open iham opened 5 years ago

iham commented 5 years ago

fixes screenshot cropping for displays with higher pixel denisity then 1.

also calculates top based on the scroll position.

@datakurre please merge and release or add me as maintainer to pypi. please also think about moving the package to the collective and add collective user to pypi, if you don't have time for maintaining this project all on yourself.

datakurre commented 5 years ago

I could move this to collective and give you PyPI rights. Thanks. FYI: There’s now also robotframework-seleniumscreenshots, which I do maintain. On 7 Feb 2019, 16.30 +0200, Markus Hilbert notifications@github.com, wrote:

fixes screenshot cropping for displays with higher pixel denisity then 1. also calculates top based on the scroll position. @datakurre please merge and release or add me as maintainer to pypi. please also think about moving the package to the collective and add collective user to pypi, if you don't have time for maintaining this project all on yourself. You can view, comment on, or merge this pull request online at: https://github.com/datakurre/robotframework-selenium2screenshots/pull/17 Commit Summary

• Fixed "Crop page screenshot" to recognize scrolled position and pixel ratio.

File Changes

• M CHANGES.txt (3) • M src/Selenium2Screenshots/keywords.robot (11)

Patch Links:

• https://github.com/datakurre/robotframework-selenium2screenshots/pull/17.patch • https://github.com/datakurre/robotframework-selenium2screenshots/pull/17.diff

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

iham commented 5 years ago

yes, please add me (iham) and collective to pypi as maintainers :)

datakurre commented 5 years ago
datakurre commented 5 years ago

@iham Done. Go for merge and release! Thank you!

When I have more time, I'll make sure that this is also taken account in robotframework-seleniumscreenshots (it depends on robotframework-seleniumscreenshots instead of the 2-version and is also refactored into Python keyword library instead of robot files).