Review language code at facebook plugin

collective / sc.social.like

Social: Like Actions is a Plone package (add-on) providing simple Google+, Twitter and Facebook integration for Plone Content Types.

7 stars 23 forks source link

Review language code at facebook plugin #122

Open rodfersou opened 7 years ago

rodfersou commented 7 years ago

It looks like we have a bug there: https://github.com/collective/sc.social.like/pull/121/files#r129295520

hvelarde commented 7 years ago

I don't think we have a bug; that's too obvious: every site would be displaying now a wdget in English and that's not the case. probably the error is on the test.

rodfersou commented 7 years ago

@hvelarde create a new site, don't change the language, and our plugin is guessing en_GB instead of en_US. The test is right, there is a bug, not important bug since the translated words are probably the same, but still it is a bug.