search

collective / sc.social.like

Social: Like Actions is a Plone package (add-on) providing simple Google+, Twitter and Facebook integration for Plone Content Types.
7 stars 23 forks source link

Remove upgrade steps for old, unsupported releases #162

Open hvelarde opened 6 years ago

hvelarde commented 6 years ago

Version 2.2 is now 3-years old and we are not going to maintain it.

hvelarde commented 6 years ago

@idgserpro I'm not a huge fan of maintaining old code in add-ons because it complicates our lives.

I have no problem bumping a major version if you feel more comfortable with that.

idgserpro commented 6 years ago

I'm not a huge fan of maintaining old code in add-ons because it complicates our lives.

I know that. See, I'm not against removing it, specially because you're the original maintainers of this project, and it's up to you to decide how to use your resources.

But try to imagine the scenario I pointed out in https://github.com/collective/sc.social.like/pull/162#pullrequestreview-126346878: Imagine it's you upgrading from 2.x to 2.13 (final), everything is broken and after some researching you get to know that you need to upgrade first to 2.13b3 before upgrading to 2.13... such a MINOR change (semver nomenclature) shouldn't break like that.

But if it's a MAJOR change, at least some breakage is expected and if someone didn't read the changelog before upgrading from 2.x to 3.x, I'm sorry, it's their fault.

hvelarde commented 6 years ago

no, I'm not going to maintain any 2.x branch after this bump as it makes no sense.

I can create it, just because is the right thing to do, but I'm not going to touch it at all.

hvelarde commented 6 years ago

@idgserpro do you agree? please approve.

idgserpro commented 6 years ago

So, with a branch 2.x, if needed, a new upgradeStep will be 3011? 9 upgradeSteps at most since the 3.x package will begin with 3020?

hvelarde commented 6 years ago

I think add-ons are different from projects like IDG: as mentioned in other place, we don't want to maintain a 2.x branch because it just don't make sense.

we are bumping the major release just to inform that we're breaking things.

idgserpro commented 6 years ago

Well, a 2.x branch can be created in the future if if needed, a commit before this one.

hvelarde commented 6 years ago

can you approve now? ;)

Rudd-O commented 2 years ago

It's high time this project was cleaned up a bit and bumped to a newer major version. It's fine if you want to keep old compat code to ease upgrade between major Plone versions... but the project as it exists today has several bugs that should be fixed.