search

collective / sc.social.like

Social: Like Actions is a Plone package (add-on) providing simple Google+, Twitter and Facebook integration for Plone Content Types.
7 stars 23 forks source link

Unhide WhatsApp #192

Closed Rudd-O closed 1 year ago

Rudd-O commented 2 years ago

There is no reason whatsoever to hide the WhatsApp social icon when it is enabled.

Rudd-O commented 2 years ago

How do I merge?

Rudd-O commented 2 years ago

Still can't merge, checks haven't completed yet.

Rudd-O commented 2 years ago

Why can't I merge this still?

Rudd-O commented 1 year ago

When is this going to get approved?

Rudd-O commented 1 year ago

Note this was opened in FEBRUARY.

ale-rt commented 1 year ago

AFAICS checking the code through github the active class is set by this JavaScript on mobile: https://github.com/collective/sc.social.like/blob/95b69b548f980498abbfb71be9da93eac9dd02b1/sc/social/like/browser/scripts/social_like.js#L16

I have no idea why this behavior is in place.

Rudd-O commented 1 year ago

I still can't merge.

Rudd-O commented 1 year ago

Please merge this already.

gforcada commented 1 year ago

Seems that master branch is protected, and then if GHA do not pass or you are not an admin of the organization you can not merge PRs...

Should we disable that? 🤔

Rudd-O commented 1 year ago

I would not mind if it was disabled, but the tests didn't even run, that's what my problem was.

gforcada commented 1 year ago

Oh, I see, well, given that there is not GitHub Actions configured and Travis CI is no longer working, it's difficult to get tests running 😓