search

collective / sc.social.like

Social: Like Actions is a Plone package (add-on) providing simple Google+, Twitter and Facebook integration for Plone Content Types.
7 stars 23 forks source link

Icons not shown under Plone 5 #99

Open hvelarde opened 7 years ago

hvelarde commented 7 years ago

Email, WhatsApp and Telegram icons are not being loaded in Plone 5:

selection_018

rodfersou commented 7 years ago

I had the same problem in other package.. it looks like we need to add extra / before the ++resource at css files to work with both Plone 4 and Plone 5

NightWorx commented 6 years ago

Error thrown when trying to activate social.like in PloneAddons configlet SassSyntaxError: Syntax error after u'_images/ico-whatsapp': Found u'.svg)' but expected one of ",", ":",

hvelarde commented 6 years ago

@NightWorx thanks, this package is still not compatible with Plone 5; we will address that in the comming months.

tkimnguyen commented 5 years ago

this package is still not compatible with Plone 5

Ah, the README is a bit misleading because it mentions Plone 5 (and I just ran into a problem activating it in Plone 5.1.4...)

hvelarde commented 5 years ago

package still needs some love to make it Plone 5.1 compatible.

tkimnguyen commented 5 years ago

Ah then in the meantime the setup.py needs to include the Plone 5.0 classifier and maybe needs some clarification in the README... I'm on it

hvelarde commented 5 years ago

I don't think the package is compatible with Plone 5.0.

tkimnguyen commented 5 years ago

It worked for me in Plone 5.0.8. Buildout was ok, instance started ok, activation of add-on was ok. I saw the Twitter share icon appear. (However I did not see the Facebook icon show up but didn't know if that was because I might have blocking set up).

hvelarde commented 5 years ago

you have to add the FB admin information in order to activate it, see: https://github.com/collective/sc.social.like/issues/158

tkimnguyen commented 5 years ago

Ah, might be good then to say something about this in the help text for that field? I confirm that when I entered a Facebook App ID the Facebook share icon showed up.