search

collective / sphinxcontrib-httpexample

Adds example directive for sphinx-contrib httpdomain
23 stars 20 forks source link

Only application/json is supported #11

Closed jaroel closed 7 years ago

jaroel commented 7 years ago

I'm working on examples that issue PATCH requests using Content-Type: application/offset+octet-stream. I'm a bit confused on why there is an explicit check for application/json in here?

datakurre commented 7 years ago

It could be, but only because there was no examples / tests with other content types before. So, "just" add a test for your use case and adapt the code to work with it :)

On 9. toukokuuta 2017 klo 18.07 +0300, Roel Bruggink notifications@github.com, wrote:

I'm working on examples that issue PATCH requests using Content-Type: application/offset+octet-stream. I'm a bit confused on why there is an explicit check for application/json in here?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://github.com/collective/sphinxcontrib-httpexample/issues/11), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAJyv4P68Nj9X29PPB8_8OtrEKEjr7Qmks5r4HqZgaJpZM4NVamG).