search

collective / sphinxcontrib-httpexample

Adds example directive for sphinx-contrib httpdomain
23 stars 20 forks source link

Support non-json requests. #12

Closed jaroel closed 7 years ago

jaroel commented 7 years ago

Closes #11

jaroel commented 7 years ago

@datakurre any idea why the tests are failing only on travis, works-on-my-machine ?

datakurre commented 7 years ago

@jaroel Don't worry. I'll check this today.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.2%) to 96.167% when pulling 065d5c42b39929508a24f5a0a18df4ff61804be6 on non-json-support into 50226e3bd358f0970b4a8f6f7be955baeab52805 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.2%) to 96.167% when pulling 065d5c42b39929508a24f5a0a18df4ff61804be6 on non-json-support into 50226e3bd358f0970b4a8f6f7be955baeab52805 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.2%) to 96.167% when pulling 065d5c42b39929508a24f5a0a18df4ff61804be6 on non-json-support into 50226e3bd358f0970b4a8f6f7be955baeab52805 on master.

jaroel commented 7 years ago

@datakurre awesome, thank you!

datakurre commented 7 years ago

The tests only failed on Python 3 (because bytes were printed with b''). There was issue in Python 2 build, which did hide the issue. (The build did first properly run tests for Python 2, but then also on Python 3 which failed.)

I'm a bit sorry for the nix based setup here, but I want to learn it more somewhere and it was the part of fun in this project.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.2%) to 96.864% when pulling 9398da363b61d15b5d26b3c6704322a111a0a62e on non-json-support into a07d9348f0a55b3804787b0ae0bd4375db4730d0 on master.