collective / volto-form-block

Volto addon for a customizable form block
MIT License
9 stars 8 forks source link

JS console error: onChangeFocus marked as required in EditBlock #80

Open mauritsvanrees opened 9 months ago

mauritsvanrees commented 9 months ago

In a test project with volto-form-block and volto-sub-blocks I see this error on the javascript console when adding a form block to a page:

Warning: Failed prop type: The prop onChangeFocus is marked as required in EditBlock, but its value is undefined.

(Yes, it is an error even though it starts with "Warning"...)

I guess it is about this EditBlock class in the current repo. And onChangeFocus is marked as required in volto-subblocks.

I don't know what a proper fix would be: add EditBlock.onChangeFocus = false or true, or I guess a function, though I do not know what this function would have to do. Or maybe make onChangeFocus not required.

In my case, due to this error I actually thought the block was broken, maybe not yet compatible with Volto 17, or with volto-light-theme, because it was not working. In fact it worked fine. I simply did not yet understand the UI: I expected that I could add fields in the main part of the edit page, but you can only do this in the "side column" (I don't know if that is the right term).