search

collective / volto-hydra

A volto addon to let you edit content in realtime when you have many frontends written in any framework
1 stars 2 forks source link

See real time updates when you change title in sidebar #49

Closed MAX-786 closed 3 months ago

MAX-786 commented 3 months ago

Fixes #39

https://github.com/collective/volto-hydra/assets/99530996/a3e3b560-5e78-4982-80b5-31c07096ad92

MAX-786 commented 3 months ago

Reference data parameter as same as ploneClient data.

JeffersonBledsoe commented 3 months ago

@MAX-786 Logic all looks fine (I didn't dive too deeply, but it all seems to work well!), I've left a few review comments to improve code readability. I'm happy to merge once those are all resolved

JeffersonBledsoe commented 3 months ago

Assuming the other PR resolves all the noted comments, looks good to me! @djay Happy to merge?

MAX-786 commented 3 months ago

Assuming the other PR resolves all the noted comments, looks good to me!

for reference this one I was talking abt PR Made those changes before the review so i thought of keeping them there :)