collective / volto-hydra

A volto addon to let you edit content in realtime when you have many frontends written in any framework
0 stars 2 forks source link

Realtime Editing fix #91

Closed JeffersonBledsoe closed 1 week ago

JeffersonBledsoe commented 1 week ago

The bridgeInstance is appearing as null, causing the onEditChange callback registration to get skipped. I think this is due to the useEffect I've changed in this PR not having a dependency array, causing it to run every render and potentially causing a race condition. I had some sporadic errors with the @/utils imports whilst developing so switched them to use ES Module imports which seems to work better.

MAX-786 commented 1 week ago

Real time updates are working and there's little instructions update in readme.

MAX-786 commented 1 week ago

@JeffersonBledsoe LGTM! can be merged now.