Menu item reorder and filtering patch

collective / webcouturier.dropdownmenu

Dropdown menus for Plone

https://pypi.python.org/pypi/webcouturier.dropdownmenu

4 stars 15 forks source link

Menu item reorder and filtering patch #8

Closed miohtama closed 8 years ago

miohtama commented 12 years ago

I have created a patch which adds support for per-folder menu item filtering and reordering. This allows you fine-tune your dropdown menu content to differ from the actual sitemap. For example, in some cases you want less items appear in the menu than in the sitemap.

This happens by having new Action menu item "Dropdown menu settings" on folders. There you have a z3c.form which allows you select and reorder content items.

The (unfinished) code is here: https://github.com/miohtama/webcouturier.dropdownmenu

Before proceeding with unit testing and documention I'd like to know which is BBB policy of webcouturier.dropdownmenu.

Code is Plone 4.0+ / Python 2.6 only, though it can be modified to just not have the new functionality on older Plone versions
The form machinery uses plone.form.directives which depends on five.grok which some people don't like. However this makes form code very compact and easy to maintain and doing it with barebone z3c.form / ZCML would double the number of code lines

So the questions

Is plone.form.directives ok dependency
Is Plone 4+ ok target or must the backwards compatiblity to Plone 3 retained with new releases

toutpt commented 12 years ago

I have nothing against theses technologies.

But I believe this could be an addon because it's a new feature.

collective.filtreddropdown for example. and so I believe this is better for 'thoses' who don't like to depends on grok and other new technologies.

Let me know your believe on this ?

No way to maintains Plone3 compat.

miohtama commented 12 years ago

The code touches the core parts of webcouturier.dropdownmenu which are hard to modulize. If it's an add-on then it is the same to fork the whole project :(

toutpt commented 12 years ago

Hi Mikko,

I have read the code and think about it.

There are many new dependencies: five.grok, plone.directives.form, plone.behavior and this addon is really simple at the moment so I would like to keep that simple.

So please release it with a new name. IMO this is better to have many addons to let the choice to integrators which one to use. I have many customer would love to get that configurable dropdown menu. Let me know the name you will use and don't let it as a fork please.

Regards / Cordialement, JeanMichel FRANCOIS Find me on Twitter http://twitter.com/toutpt / Retrouvez moi sur Twitterhttp://twitter.com/toutpt_nantes

2012/7/3 Mikko Ohtamaa < reply@reply.github.com

The code touches the core parts of webcouturier.dropdownmenu which are hard to modulize. If it's an add-on then it is the same to fork the whole project :(

Reply to this email directly or view it on GitHub:

https://github.com/collective/webcouturier.dropdownmenu/issues/8#issuecomment-6738756

miohtama commented 12 years ago

How about if I simplify and leave away grok and rewrite parts of it using pure Zope 3 and ZCML? This makes less dependencies, but leaves still the code in-place.

toutpt commented 12 years ago

As I said in my first email,

I believe this could be an addon because it's a new feature. it should be better for both: community and marketing to have more addons with their own special stuff. quintagroup.dropdown is not my favorite and your is a more advanced needs (filtering).

Regards / Cordialement, JeanMichel FRANCOIS Find me on Twitter http://twitter.com/toutpt / Retrouvez moi sur Twitterhttp://twitter.com/toutpt_nantes

2012/7/26 Mikko Ohtamaa < reply@reply.github.com

How about if I simplify and leave away grok and rewrite parts of it using pure Zope 3 and ZCML?

Reply to this email directly or view it on GitHub:

https://github.com/collective/webcouturier.dropdownmenu/issues/8#issuecomment-7274790

jensens commented 8 years ago

I'd say this one is outdated.