search

collective / wildcard.media

13 stars 12 forks source link

Do not show "Convert Video" action under portal_actions for Audio objects #27

Open neilferreira opened 8 years ago

neilferreira commented 8 years ago

Currently the Audio objects have a Convert Audio link which simply errors because of a missing video attribute.

I have fixed this by doing: https://github.com/neilferreira/wildcard.media/commit/95547c1f611f4e9f8885bbeab6baec6b5d0b5a61

neilferreira commented 8 years ago

I just realized that because I removed the actual method from the Utils class that it would break any existing sites that update their version without re-installing the addon.

vangheem commented 8 years ago

Maybe just leave the method there, add a deprecation note and provide an upgrade step?