Add celery integration and upgrade javascript

collective / wildcard.media

13 stars 12 forks source link

Add celery integration and upgrade javascript #52

Open runyaga opened 5 years ago

runyaga commented 5 years ago

Upgrade to latest mediaelementjs
Add collective.celery integration (requires latest collective.celery pull request)
If x-send-file is being used opt out of that on stream view (requires latest of that package as well)

djay commented 5 years ago

@runyaga would have been nice to split that into different PRs. I'm assuming it still works with p.a.async right?

djay commented 5 years ago

@runyaga also whats the reason to opt out of x-send-file? I specifically made it work with wc.media if I remember it right?

runyaga commented 5 years ago

yes it should still works with p.a.async. we only have to disable x-sendfile for the streaming view. when GET the media file directly it uses x-sendfile will not be able to break up until smaller PR for awhile.

djay commented 5 years ago

@runyaga why do you want to disable x-sendfile for the streaming view. We used it successfully with streaming and it enabled much better scaling due to HAproxy or other loadbalancers not being able to know that zope is capable of handling another request even if it is streaming.

runyaga commented 5 years ago

@djay https://github.com/nmaier/mod_xsendfile/issues/37 appears others are having issues with range support. we cant get range support working. we hope to move to nginx in the near future for this project.