search

collective / wildcard.media

13 stars 12 forks source link

WIP: fixed hardcoded enclosure on AudioFeedItem #63

Open pigeonflight opened 5 years ago

pigeonflight commented 5 years ago

has_enclosure is hardcoded for AudioFeedItem but not for VideoFeedItem. see: https://github.com/collective/wildcard.media/blob/master/wildcard/media/browser/syndication.py#L11-L13

This breaks social tags on plone.app.layout 2.5.x on In Plone 5.0.x. Resulting in an "error while rendering plone.htmlhead.socialtags" on Plone 5.0.x

This pull request fixes the issue by providing a proper has_enclosure for AudioFeedItem

I've marked it WIP as I need to add some tests etc...