search

collective / zestreleaser.towncrier

GNU General Public License v2.0
1 stars 1 forks source link

Add build subcommand to towncrier when building the changelog #22

Closed mcflugen closed 2 years ago

mcflugen commented 2 years ago

This pull request is meant to address #21 by adding the explicit build subcommand when running towncrier to create the new changelog.

That is, towncrier build --draft --version t.b.d instead of towncrier --draft --version t.b.d.

It appears that towncrier has accepted the build subcommand for quite some time so there shouldn't be any backward compatibility issues.

mcflugen commented 2 years ago

It looks like it was introduced with twisted/towncrier#145 (March 2019). I checked and v19.2 doesn't have it but 19.9 does have it. So I guess requiring "towncrier>=19.9.0" should do the trick?

mauritsvanrees commented 2 years ago

Thanks. I have added towncrier 19.9.0 as minimum version in setup.py. I have released this as version 1.3.0 (including using tomli instead of toml when possible).

mcflugen commented 2 years ago

Yay, that's great! 🎉

I just realized that I had forgotten to include a news fragment in my pull request! 🤦