search

collective / zestreleaser.towncrier

GNU General Public License v2.0
1 stars 1 forks source link

Hook should fail or warn when towncrier is required #7

Closed mauritsvanrees closed 5 years ago

mauritsvanrees commented 5 years ago

If the package that is being released has a pyproject.toml with towncrier config, and we cannot find the towncrier executable, then our hook should either warn about this or fail with an error. Probably a question is best:

According to the pyproject.toml file, towncrier is used to update the changelog. The problem is: we cannot find the towncrier executable. Please make sure it is on your PATH. Do you want to continue anyway? (y/N)

Default answer would be no, at which point we would do a sys.exit(1).

mauritsvanrees commented 5 years ago

Thanks for the review and merge. I have released this as 1.0.0.