Thumbnail Click Not Updating Representation Viewer

collectiveaccess / pawtucket2

Pawtucket Improved

GNU General Public License v3.0

85 stars 76 forks source link

Thumbnail Click Not Updating Representation Viewer #112

Closed ChiaChing-Yen closed 2 months ago

ChiaChing-Yen commented 2 months ago

On object detail view, clicking thumbnails fails to update the representation viewer for objects with multiple representations.

Steps to Reproduce

PHP version: 8.1.29, Git clone from dev/php8 branch then Composer install
Use Dublin Core profile (2018), leave everything else in default
Create new object with two different representations
On detail view, click different thumbnails

miqrogroove commented 2 months ago

I'm working on an implementation for this. Javascript is not my language, but this feature is important for me.

collectiveaccess commented 2 months ago

It was reimplemented already to avoid using jcarousel, which is the cause of the issue. Older themes will need to change the "linkTo" option in caObjectRepresentationThumbnails(). This is usually called in the object detail views. I've just pushed a change to default to account for this. It had only been set in themes we actively develop previously.

miqrogroove commented 2 months ago

I can build off of that. There's still a bunch of code missing.

collectiveaccess commented 2 months ago

It works ok. Anything you build should be in your own theme, not default.

miqrogroove commented 2 months ago

I'll open a new issue and call it a bug then. There's no reason to leave incomplete code in the default theme.

collectiveaccess commented 2 months ago

What exactly is incomplete?