search

collectiveaccess / pawtucket2

Pawtucket Improved
GNU General Public License v3.0
85 stars 76 forks source link

Object Display Broken by Recent Commit #124

Closed miqrogroove closed 2 months ago

miqrogroove commented 2 months ago

Testing uninitialized variable o > 0 prevents the object detail page from displaying any media.

https://github.com/collectiveaccess/pawtucket2/blob/a64c94ed29b7b16cc3590fa4980c6c8b60ed25e4/themes/default/views/bundles/representation_viewer_html.php#L85

Also, this does not resolve #123 as the global value remains set to zero in that case.

miqrogroove commented 2 months ago

Fixed by https://github.com/collectiveaccess/pawtucket2/commit/108f2c4b538f38365178a2ad48e7773040ee655e and https://github.com/collectiveaccess/pawtucket2/commit/43d90767bd0588b162c19c437b8274d2af77edfa