collectiveaccess / pawtucket2

Pawtucket Improved
GNU General Public License v3.0
82 stars 75 forks source link

Refactored Rep Thumbnail Clicks #129

Closed miqrogroove closed 5 days ago

miqrogroove commented 5 days ago

Fixes #127

The previous implementation assumed slides could be indexed using the thumbnail sequence, which does not work because thumbnails and slides are not in the same order unless the primary representation happens to be first.

This PR refactors the function setItem to assume the input is a thumbnail sequence number, not the slide array index and not the representation ID. This function grabs the thumbnail's representation ID and scans the slide list to find the corresponding slide index.

Added function setByIndex which assumes the input is the targeted slide array index. This function extracts the representation ID from the slide list and uses it to find the element ID of a corresponding thumbnail.