search

collectiveaccess / pawtucket2

Pawtucket Improved
GNU General Public License v3.0
82 stars 75 forks source link

Entities without IDs do not reolve when use_identifiers_in_urls = 1 #30

Closed dullj closed 2 years ago

dullj commented 2 years ago

We've copied things to a new server, updated from 1.7.9 to 1.7.13 (db schema 158), and created a new theme.

When use_identifiers_in_urls was set to 0 in the new theme, the URLs resolved correctly. When we changed the value to 1, entities without IDs no longer resolve and the URL encoding seems to not work. We did not have this issue in our past installation. I'm trying to track down where this is happening. Here are examples from the 2 servers old and new. Old install: https://digitalarchives.library.newschool.edu/index.php/Detail/people/id%3A4079 New Install: https://dev-digital.archives.newschool.edu/index.php/Detail/entities/id%3A4079

if you manually replace the '%3A' with the deencoded ':', the URL resolves correctly.

dullj commented 2 years ago

We've also noticed that Object IDs with hyphens '-' or spaces ' ' are also not resolving even though they did in our old instance.

katiemartinez commented 2 years ago

@collectiveaccess Hi there, wondering if you have an idea of when this might be resolved? We have a large group of users scheduled to access our collections soon and we were hoping to go live with the new install.

collectiveaccess commented 2 years ago

We'll get to it when we can.

collectiveaccess commented 2 years ago

Just pushed a fix for this. Please do a pull on master and let me know if it works for you. If it does we'll put it in a 1.7.14 release.

dullj commented 2 years ago

I pushed this change out this morning. It has fixed the issues we reported above. The URLs that weren't resolving before b/c of certain characters are working now. Thank you! 🥇