search

collectiveaccess / pawtucket2

Pawtucket Improved
GNU General Public License v3.0
82 stars 75 forks source link

Fix/html formhelper keys #58

Closed peterjanssens closed 1 year ago

peterjanssens commented 1 year ago

some value initialisation problems, mixed with wrong keys (value vs values)

collectiveaccess commented 1 year ago

Thanks for this one. The "value" vs. "values" key differences are intentional and required to support both "value" and "values" options, the former being for a single selected value.

I'm going to merge in your initialization separately and add comments to explain what's going on in this bit of code. So I am closing this PR now.

peterjanssens commented 1 year ago

thx for the update, some things like that are not always clear without (historical) context :)

collectiveaccess commented 1 year ago

In this case it's very old history (like from ~2005!)